Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some typos #1565

Merged
merged 1 commit into from
Feb 10, 2025
Merged

chore: fix some typos #1565

merged 1 commit into from
Feb 10, 2025

Conversation

zoupingshi
Copy link
Contributor

No description provided.

Signed-off-by: zoupingshi <[email protected]>
Copy link
Collaborator

@jp1ac4 jp1ac4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 37f0d54. Thanks!

@@ -1054,7 +1054,7 @@ CREATE TABLE tip (
* now (and the foreseeable future).
*
* The 'timestamp' field is the creation date of the wallet. We guarantee to have seen all
* information related to our descriptor(s) that occured after this date.
* information related to our descriptor(s) that occurred after this date.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is the V3_SCHEMA used for tests, it could be argued that it shouldn't be modified in any way so that it exactly matches the schema used in that version, but I think updating the comment is fine as it won't affect the tests.

@edouardparis edouardparis merged commit a46cb5f into wizardsardine:master Feb 10, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants